feature/ipfs-lib-migration #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukachi
reviewed
Aug 16, 2023
CHANGELOG.md
Outdated
| @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [0.0.0-rc.19] - 2023-08-15 | |||
| ### Changed | |||
| - `@tokene/toolkit` - `IpfsUtil` class now is using `kubo-rpc-client` | |||
There was a problem hiding this comment.
replaced ipfs-http-client by kubo-rpc-client
|
|
||
| import { toolkitConfig } from '@/globals' | ||
|
|
||
| const PREFIX = 'ipfs://' | ||
|
|
||
| export class IpfsUtil<T> { | ||
| private _rawData?: T | ||
| private _path?: string | ||
| private _paths = [] as string[] | ||
| private _cid?: string |
There was a problem hiding this comment.
id add and addAll returns path, should we use this.path instead of cid?
There was a problem hiding this comment.
Yes, we can rename getters because we return a cid paths, but in class we're using cids, not cid paths.
Sorizen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.